Modify ↓

Opened 14 years ago

Closed 13 years ago

#52 closed defect (fixed)

Non-portable pthreads detection in pcitool, rev 156

Reported by: Matthias Vogelgesang Owned by: Suren A. Chilingaryan
Priority: blocker Milestone:
Component: pcilib Version:
Keywords: Cc:

Description

You should definately make use of the Threads module that is contained with CMake. It will tell you if libraries are available, you can use target_link_libraries() and it will also work with non-gcc compilers.

Attachments (0)

Change History (5)

comment:1 Changed 14 years ago by Suren A. Chilingaryan

Thanks. Can you post an example here to save me googling?

comment:3 Changed 14 years ago by Suren A. Chilingaryan

Resolution: → fixed
Status: new → closed

Thanks, fixed.

comment:4 Changed 13 years ago by Matthias Vogelgesang

Priority: minor → blocker
Resolution: fixed
Status: closed → reopened
Type: enhancement → defect

This now caused severe problems on Ubuntu 12.04 at HZG where pcitool couldn't be built.

The problem occurs because you manually override LINK_FLAGS instead of using the suggested target_link_libraries(pci ${CMAKE_THREAD_LIBS_INIT}) function.

comment:5 Changed 13 years ago by Suren A. Chilingaryan

Resolution: → fixed
Status: reopened → closed

Thanks

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Suren A. Chilingaryan.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.